Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE]Restore the Delete button for server in diagnostics #3763

Merged
merged 2 commits into from
Apr 16, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Apr 12, 2018

Restore the Delete button for servers in a zone, selected from the right-side "Roles By Servers" tab

Links

Fine backport for #2213
https://bugzilla.redhat.com/show_bug.cgi?id=1566746

After:
screenshot from 2018-04-13 09-55-01

@miq-bot miq-bot changed the title [WIP] Restore the Delete button for server in diagnostics [FINE] [WIP] Restore the Delete button for server in diagnostics Apr 12, 2018
@miq-bot miq-bot added the wip label Apr 12, 2018
@lgalis lgalis force-pushed the fine_restore_delete_server_button_diag branch from 7b5e3f6 to 16bfca2 Compare April 13, 2018 13:04
@lgalis lgalis changed the title [FINE] [WIP] Restore the Delete button for server in diagnostics [FINE] Restore the Delete button for server in diagnostics Apr 13, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Apr 13, 2018

@miq-bot add_label bug, settings

@lgalis
Copy link
Contributor Author

lgalis commented Apr 13, 2018

@h-kataria - please review
/cc @simaishi

@lgalis lgalis changed the title [FINE] Restore the Delete button for server in diagnostics [FINE][WIP] Restore the Delete button for server in diagnostics Apr 13, 2018
@miq-bot miq-bot changed the title [FINE][WIP] Restore the Delete button for server in diagnostics [WIP] [FINE][WIP] Restore the Delete button for server in diagnostics Apr 13, 2018
@miq-bot miq-bot added the wip label Apr 13, 2018
@lgalis lgalis force-pushed the fine_restore_delete_server_button_diag branch from 16bfca2 to 380a5f1 Compare April 13, 2018 13:26
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2018

Checked commits lgalis/manageiq-ui-classic@380a5f1~...9f37b6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

@lgalis lgalis changed the title [WIP] [FINE][WIP] Restore the Delete button for server in diagnostics [FINE]Restore the Delete button for server in diagnostics Apr 13, 2018
@miq-bot miq-bot removed the wip label Apr 13, 2018
@JPrause
Copy link
Member

JPrause commented Apr 13, 2018

@miq-bot add_label blocker

@simaishi simaishi requested a review from h-kataria April 13, 2018 15:33
@simaishi simaishi self-assigned this Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants