Swap the save/cancel buttons on the dialog editor to be consistent #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_reviewer @epwinchell |
|
Checked commit skateman@0894e43 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman looks fine |
epwinchell
approved these changes
Apr 11, 2018
|
@epwinchell unrecognized command 'rm_reviewer', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot assign @mzazrivec |
romanblanco
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In every other form the Save button is the leftmost element on the bottom of the screen. However, the dialog editor somehow has it swapped, so changing it for the sake of consistency.
Before:
After:
@miq-bot add_reviewer @romanblanco
@miq-bot add_reviewer @himdel
@miq-bot add_label bug