Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all user form data before validating for errors per field #3714

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Apr 4, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562828

Configuration -> Access Control -> Users -> Configuration -> Add a new User -> fill as in image below -> click Add

Before:
screen shot 2018-04-04 at 9 31 20 am
After:
screen shot 2018-04-04 at 9 32 58 am

Makes sure not to re-introduced bug fixed in #3345

Steps to reproduce issue from that PR:

  • Create an RBAC user that is assigned to one or more groups
  • Edit the RBAC user and remove them from all of their assigned groups
  • Click Save
  • After receiving the error "A User must be assigned to a Group", navigate away from the user's details page.
  • Select the user in the RBAC accordion to view their details

If there's an error make sure it isn't related to #3720 fix

@miq-bot add_label bug, gaprindashvili/yes, wip

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot changed the title Get all user form data before validating for errors per field [WIP] Get all user form data before validating for errors per field Apr 4, 2018
@miq-bot miq-bot added the wip label Apr 4, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2018

Checked commits ZitaNemeckova/manageiq-ui-classic@09aa3f9~...7699935 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Get all user form data before validating for errors per field Get all user form data before validating for errors per field Apr 4, 2018
@miq-bot miq-bot removed the wip label Apr 4, 2018
@mzazrivec mzazrivec self-assigned this Apr 5, 2018
@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 5, 2018
@mzazrivec mzazrivec merged commit b55d442 into ManageIQ:master Apr 5, 2018
@himdel
Copy link
Contributor

himdel commented Apr 12, 2018

@ZitaNemeckova This breaks editing users in ops ;).

rbac_user_set_record_vars(record) needs to be called even whan saving an existing user :)

(Removed gaprindashvili/yes until this is fixed.)

@ZitaNemeckova
Copy link
Contributor Author

ZitaNemeckova commented Apr 13, 2018

Replaced/Fixed by #3767

@himdel
Copy link
Contributor

himdel commented Apr 16, 2018

@simaishi When backporting to gaprindashvili, please backport together with #3767 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants