Automatic detection of hawkular endpoint #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests refactored get_hostname_from_routes (cherry picked from commit b9d7bea3e734d433c2f217aec2c2c6146375644b)
enoodle
approved these changes
Dec 28, 2016
|
Checked commit nimrodshn@6643b0e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
yaacov
approved these changes
Dec 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added automatic detection of Hawkular hostname from route when endpoint is not specified.
When the user does not specify the Hawkular client hostname upon adding a new container provider (i.e. Hawkular endpoint is left blank) we had taken it from the hostname - this behavior is changed in this PR - now we are taking the hostname from the Route.
cc: @yaacov @enoodle @simon3z
(converted from ManageIQ/manageiq#12530)