Fix TextEncoderLite in old browsers #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ require the compat pack from jasmine (doing this in jasmine to test that TextEncoderLite actually works)
version 1.0.1 only ever exports TextDecoderLite version 1.0.2 fixed this, but was not released yet
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/56d42d95866730faf8e0fa6e9dca7df08bbfbdb8~...a9f34d1961f1ceab7311b425cf82b2423b1784f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
Fix TextEncoderLite in old browsers (cherry picked from commit 8897622) https://bugzilla.redhat.com/show_bug.cgi?id=1562797
|
Gaprindashvili backport details: |
|
Backported to Fine via #3711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in older browsers, introduced by #3682
#3682 adds code that uses TextEncoder in browsers which support it, and TextEncoderLite in browser which don't.
But text-encoder-lite in version 1.0.1 only ever exports the decoder part.
This was fixed in 1.0.2 .. but that one never got released.
So.. updating to the new version (by commit), and adding a spec that will use the Lite version (because phantomjs doesn't have TextEncoder).
Ping @mzazrivec ;)