-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertical_navbar - a element to use exisitng param, href #3683
Conversation
@ZitaNemeckova Are these changes OK with you? |
This looks wrong. This should be (For ordinary menu items, the effect should be the same, but this also handles modal links, big iframe links, etc.) |
So when yah do something along the lines of (not something that happens with href, but I didn't check any modals either 😢 ) I see the definition though,
maybe instead of :default 🤔 nope that doesn't make a difference. almost like we need to suppress default behavior... 🤔 |
2ba4dd1
to
1094c05
Compare
OH it all makes sense now. Please disregard previous mental flailing. Updated. |
Checked commit AllenBW@1094c05 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
I tried it with https://github.com/priley86/miq_v2v_ui_plugin/pull/171 .
So LGTM for manageiq-ui-classic 👍 |
#3963: Together with #3347 + #3726, fixes menu for v2v in gaprindashvili
|
vertical_navbar - a element to use exisitng param, href (cherry picked from commit 0275224)
Gaprindashvili backport details:
|
In support of https://github.com/priley86/miq_v2v_ui_plugin/issues/161 but also its a bug.
cc @ZitaNemeckova for being awesome and helping me with this 🙇♀️ ❤️