-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show message when trying to edit item with missing Provisioning request #3661
Merged
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:catalog_item_missing_request_fix
Mar 20, 2018
Merged
Show message when trying to edit item with missing Provisioning request #3661
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:catalog_item_missing_request_fix
Mar 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
catalog_item_missing_request_fix
branch
from
March 20, 2018 19:46
7f8179c
to
acfad18
Compare
Added check around code to prevent error when editing catalog item with missing Provisioning request, with this change, flash message will be displayed on the screen informing user that they can not proceed with editing selected catalog item because request is missing Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476949
h-kataria
force-pushed
the
catalog_item_missing_request_fix
branch
from
March 20, 2018 21:36
acfad18
to
6a24e66
Compare
Checked commit h-kataria@6a24e66 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
@h-kataria Can this be |
@simaishi looks like it should be ok to backport this to Fine. |
simaishi
pushed a commit
that referenced
this pull request
Mar 23, 2018
Show message when trying to edit item with missing Provisioning request (cherry picked from commit 09b7417) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560096
Gaprindashvili backport details:
|
@h-kataria There are conflicts backporting to Fine branch. Please create a separate PR. |
Backported to Fine via #3746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check around code to prevent error when editing catalog item with missing Provisioning request, with this change, flash message will be displayed on the screen informing user that they can not proceed with editing selected catalog item because request is missing
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476949
@lgalis please review/test, to test this, you will need to delete a provisioning request associated with a catalog item manually from your database.
@dclarizio please review