Fix displaying 'CPU' and 'CPU Cores' when creating chargeback rate #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1521113 Fix displaying 'CPU Cores' instead of 'Cpu Cores' under the Group column for Allocated CPU Cores and Used CPU Cores, when creating a new chargeback rate.
|
@miq-bot add_label bug |
Fix displaying 'CPU' instead of 'Cpu' under the Group column for Allocated CPU Count/Used CPU, when adding a new tier (row under the CPU Group), when creating a new chargeback rate. Similarly, fix also displaying 'Disk I/O' (not 'Disk Io') and 'Network I/O' (not 'Net Io').
|
Checked commits hstastna/manageiq-ui-classic@86e109a~...5047a9e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
hstastna
changed the title
|
@miq-bot remove_label wip |
simaishi
pushed a commit
that referenced
this pull request
Mar 16, 2018
…U_chargeback_rate Fix displaying 'CPU' and 'CPU Cores' when creating chargeback rate (cherry picked from commit 60ed31f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557388
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1521113
Done:
Allocated CPU Cores/Used CPU Cores, when creating a new chargeback rate
when adding a new
tier(row under the CPU Group), when creating a new chargeback rateNote: I used the same way (and working!) of displaying a group in the table as it is in more other places, for example:
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/chargeback/_cb_rate_edit_table.html.haml#L33
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/chargeback/_cb_rate_show.html.haml#L41
so I consider the code (2nd commit in this PR) more consistent than it was before
Note 2: We create new Compute or Storage chargeback rates under Cloud Intel > Chargeback > Rates accordion.
Before:
Displaying Cpu Cores:
Displaying Cpu, Disk Io, Net Io, after adding a new tier:
After:
Displaying CPU Cores:
Displaying CPU, Disk I/O, Network I/O, after adding a new tier: