Do not display GTL toolbars on non-GTL screens when navigating from the list #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug,generic objects |
|
Checked commits AparnaKarve/manageiq-ui-classic@f2351bc~...7957c0b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 16, 2018
Do not display GTL toolbars on non-GTL screens when navigating from the list (cherry picked from commit ff32cf8) https://bugzilla.redhat.com/show_bug.cgi?id=1557384
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when navigating from the GO Definition list, the GTL buttons are displayed in the GO Definition Summary screen, which is not correct.
This issue is also visible on other summary screens like Custom Button, Custom Group(non-GTL screens) when the view is reloaded.
Navigating from the tree, however, displays the correct toolbar with no GTL buttons.
The PR fixes this inconsistency.
Before (List navigation shows GTL buttons in Summary screen) -
After (List navigation does not show GTL buttons in Summary screen) -
https://bugzilla.redhat.com/show_bug.cgi?id=1545835