Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compare and drift field counters #3578

Merged
merged 5 commits into from
Mar 21, 2018
Merged

Fix compare and drift field counters #3578

merged 5 commits into from
Mar 21, 2018

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Mar 12, 2018 •
edited by simaishi
Loading

@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch from c3031a4 to 0d0ca4e Compare March 14, 2018 16:45
@slemrmartin slemrmartin changed the title [WIP] Fix compare cluster's counter Fix compare cluster's counter Mar 14, 2018
@slemrmartin
Copy link
Contributor Author

@miq-bot assign @martinpovolny

@miq-bot miq-bot removed the wip label Mar 14, 2018
@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch from 8153808 to bb27ad8 Compare March 14, 2018 17:24
@slemrmartin
Copy link
Contributor Author

Comparing EMS clusters shows wrong count for different options includes 'All attributes',
'Attributes with different values' and 'Attributes with same values'

Path: Compute > Infrastructure > Clusters (check 2+ clusters) -> Toolbar button 'Compare selected items'
see attached video: https://goo.gl/KbjRMw

@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch from bb27ad8 to c293490 Compare March 14, 2018 17:39
@martinpovolny
Copy link
Member

Cool!

Is there a BZ? Can you link it?

Thx!

@slemrmartin
Copy link
Contributor Author

https://bugzilla.redhat.com/show_bug.cgi?id=1469111

@slemrmartin
Copy link
Contributor Author

slemrmartin commented Mar 19, 2018 •
edited
Loading

Same problem occurs on more places (and is solved by this PR):

  • Compute -> Infrastructure -> Clusters [subject of this PR]
  • Compute -> Infrastructure -> Hosts
  • Compute -> Infrastructure -> Virtual Machines
  • Compute -> Clouds -> Instances
  • Compute -> Clouds -> Availability Zones -> [detail] -> Instances

@slemrmartin slemrmartin changed the title Fix compare cluster's counter [WIP] Fix compare cluster's counter Mar 19, 2018
@miq-bot miq-bot added the wip label Mar 19, 2018
@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch from c293490 to 28f5fa1 Compare March 19, 2018 17:47
@slemrmartin
Copy link
Contributor Author

also applicable to Drifts (similar problem, but different code):

  • Compute -> Infrastructure -> Clusters -> [detail]
  • Compute -> Infrastructure -> Hosts -> [detail]

then button "Perform Smart state analysis" (at least twice) -> Refresh page and go to Drift history
-> Check 2+ histories and push button "Select Up to 10 timestamps for Drift Analysis"

@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch 2 times, most recently from d0642fc to 7215ad3 Compare March 19, 2018 20:13
@slemrmartin slemrmartin force-pushed the fixing_compare_cluster_matches_count branch from 7215ad3 to 41646df Compare March 19, 2018 20:35
@miq-bot
Copy link
Member

miq-bot commented Mar 19, 2018

Checked commits slemrmartin/manageiq-ui-classic@4a04f4f~...41646df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@slemrmartin slemrmartin changed the title [WIP] Fix compare cluster's counter Fix compare cluster's counter Mar 20, 2018
@miq-bot miq-bot removed the wip label Mar 20, 2018
@slemrmartin slemrmartin changed the title Fix compare cluster's counter Fix compare and drift field counters Mar 20, 2018
@martinpovolny martinpovolny merged commit 2827af2 into ManageIQ:master Mar 21, 2018
@martinpovolny martinpovolny added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 21, 2018
@martinpovolny
Copy link
Member

If you have further findings, then please, create a new PR. Thx!

@martinpovolny
Copy link
Member

Gaprindashvili/no according to the BZ. Is that correct?

@slemrmartin
Copy link
Contributor Author

@miq-bot remove_label gaprindashvili/no
@miq-bot add_label gaprindashvili/yes
@miq-bot add_label fine/yes

According to BZ - it's reported to Fine (bug found in Fine, Gaprindashvili and upstream - tested by me)

@slemrmartin slemrmartin deleted the fixing_compare_cluster_matches_count branch March 21, 2018 10:14
simaishi pushed a commit that referenced this pull request Mar 23, 2018
@martinpovolny @simaishi
Merge pull request #3578 from slemrmartin/fixing_compare_cluster_matc…
48576c1 
…hes_count

Fix compare and drift field counters
(cherry picked from commit 2827af2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560100
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 48576c12131600cacf851509ba5dfe39197305da
Author: Martin Povolny <[email protected]>
Date:   Wed Mar 21 11:04:17 2018 +0100

    Merge pull request #3578 from slemrmartin/fixing_compare_cluster_matches_count
    
    Fix compare and drift field counters
    (cherry picked from commit 2827af2b358ad9e198e3fb6259939619ab58d11e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1560100

simaishi pushed a commit that referenced this pull request Apr 10, 2018
@martinpovolny @simaishi
Merge pull request #3578 from slemrmartin/fixing_compare_cluster_matc…
19a4c30 
…hes_count

Fix compare and drift field counters
(cherry picked from commit 2827af2)

https://bugzilla.redhat.com/show_bug.cgi?id=1565414
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 19a4c30644313912d1ad0ced505a8cf7faf2b662
Author: Martin Povolny <[email protected]>
Date:   Wed Mar 21 11:04:17 2018 +0100

    Merge pull request #3578 from slemrmartin/fixing_compare_cluster_matches_count
    
    Fix compare and drift field counters
    (cherry picked from commit 2827af2b358ad9e198e3fb6259939619ab58d11e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1565414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug compute/cloud compute/infrastructure fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slemrmartin @martinpovolny @miq-bot @simaishi