Webpack - CommonsChunkPlugin - force for node_modules #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonsChunkPlugin defaults to only putting libraries in vendor.js if they are used at least twice. What we really want instead is to put only external dependencies in vendor.js, regardless of how many times they are used. This ensures anything under `node_modules` will get in vendor.js
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/075041804a5b3eda2dd498611f2f1d64d523bdfa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommonsChunkPlugin defaults to only putting libraries in vendor.js if they are used at least twice.
What we really want instead is to put only external dependencies in vendor.js, regardless of how many times they are used.
This ensures anything under
node_moduleswill get in vendor.jsExtracted from #3517
(docs)