Added Max Retries text field on Instance screen

[h-kataria]

Issue# 3560

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1596338

before:

after:

[h-kataria]

@gmcculloug please review, fixes: #3560

[gmcculloug]

@tinaafitz @mkanoor Please review.

[tinaafitz]

@h-kataria Looks good.

[mkanoor]

@h-kataria
Can we add max_time also along with it since they go as a pair for state fields.
Also for non state fields can we disable those edit boxes, because they dont make sense for attributes, assertions and other field types.

[tinaafitz]

@h-kataria There are 5 fields that are only applicable to state machines:
on_entry, on_exit, on_error, max_retries, and max_time.
Would it be possible to display these fields only in the case the class is a state machine class?
You can check the class to see if its a state machine (for example MiqAeClass.first.state_machine?)
Additionally, It would be great if you were able to allow those fields to be updated only if the field was a state. (It's confusing because a class is considered a state machine class if it contains a single entry of type state. It could still have other entries of attributes, methods, and relationships)

[h-kataria]

@tinaafitz @mkanoor please review, made requested enhancements.

[tinaafitz]

@h-kataria The changes look great!

[h-kataria]

@tinaafitz @mkanoor please review, made a change as per our conversation to make "Collect" field on the form disabled if field type is not state or relationship.

[miq-bot]

Checked commits h-kataria/manageiq-ui-classic@ce2d176~...ef95156 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[gmcculloug]

@h-kataria This is looking great, thanks.

[tinaafitz]

@h-kataria Thanks for the additional change for the collect field. It looks great!
@mkanoor Please review.

[mkanoor]

@h-kataria looks great. 👍
You might want to remove the first after screen shots, it shows collect for attributes, which might confusing to documentation folks.

[h-kataria]

@mkanoor updated first screenshot

[mkanoor]

👍

[gmcculloug]

@dclarizio Would it be possible to make this gaprindashvili/yes?

Asking for a friend. @fdupont-redhat

[dclarizio]

Relabeled for gaprindashvili to address this RFE:
https://bugzilla.redhat.com/show_bug.cgi?id=1596338

[JPrause]

@miq-bot add_label blocker

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit b50a100152bfd246630121d0e0da12b499e22e89
Author: Dan Clarizio <[email protected]>
Date:   Wed Mar 14 14:42:22 2018 -0700

    Merge pull request #3562 from h-kataria/add_max_retries_for_instances
    
    Added Max Retries text field on Instance screen
    (cherry picked from commit 81d2462db09f354460390d384af6f6948ef6545e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1598528