Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hypervisor_hostname to details and list view for OS Infra Host #3561

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Adds hypervisor_hostname to details and list view for OS Infra Host #3561

merged 2 commits into from
Mar 13, 2018

Conversation

petrblaho
Copy link

Solves https://bugzilla.redhat.com/show_bug.cgi?id=1400314

Steps for Testing/QA

  1. Have OS undercloud in ManageIQ as Infra manager
  2. Go to COMPUTE > INFRASTRUCTURE > NODES > Any node
  3. Detail view should display Hypervisor Hostname
  4. Go to COMPUTE > INFRASTRUCTURE > NODES > List view
  5. Table should contain Hypervisor Hostname column

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

Checked commits https://github.com/petrblaho/manageiq-ui-classic/compare/5fd2edd20699064d8ec6bc3dad6285b7f8a6d65f~...15132194fee149e6da5cdf4dd4ab53e0ccf99627 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@petrblaho
Copy link
Author

Detail view:
hypervisor-hostname-detail-view

List view:
hypervisor-hostname-list-view

@aufi
Copy link
Member

aufi commented Mar 12, 2018

Looks good to me 👍

@serenamarie125 @Loicavenel Does this work for you?

@Loicavenel
Copy link

looks good for me

@mzazrivec mzazrivec self-assigned this Mar 13, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 13, 2018
@mzazrivec mzazrivec merged commit cee2934 into ManageIQ:master Mar 13, 2018
@petrblaho
Copy link
Author

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 16, 2018
@mzazrivec @simaishi
Merge pull request #3561 from petrblaho/bz1400314-os-infra-host-hyper…
af6bad4 
…visor-hostname

Adds hypervisor_hostname to details and list view for OS Infra Host
(cherry picked from commit cee2934)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557361
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit af6bad469deb5a12c42547850a1e2451ca79f038
Author: Milan Zázrivec <[email protected]>
Date:   Tue Mar 13 09:01:47 2018 +0100

    Merge pull request #3561 from petrblaho/bz1400314-os-infra-host-hypervisor-hostname
    
    Adds hypervisor_hostname to details and list view for OS Infra Host
    (cherry picked from commit cee29342fed1f5586efafe44ceb1b32e4e08e632)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrblaho @miq-bot @aufi @Loicavenel @simaishi @mzazrivec