Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the custom.css that bypasses the asset pipeline on every screen #3556

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Mar 9, 2018

Asset precompilation on appliances is no longer possible, however, in some cases it is necessary to have custom styling applied on a running appliance. This can only be done by bypassing the asset pipeline and loading a CSS file directly from the public folder. To avoid 404 errors an empty CSS file has been created in the core repo.

Depends on: ManageIQ/manageiq#17127
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1553353

@miq-bot add_label pending core

@himdel
Copy link
Contributor

himdel commented Mar 9, 2018

@skateman I think also app/views/dashboard/saml_login.html.haml

Otherwise LGTM 👍 (waiting for core PR)

@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

Checked commit skateman@65cd2e2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio self-assigned this Mar 9, 2018
@dclarizio dclarizio merged commit 0e08eda into ManageIQ:master Mar 9, 2018
@dclarizio dclarizio added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 9, 2018
simaishi pushed a commit that referenced this pull request Mar 9, 2018
Load the custom.css that bypasses the asset pipeline on every screen
(cherry picked from commit 0e08eda)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553841
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 0cd3c3e1963345c62d2e119552a25c2117f3adf0
Author: Dan Clarizio <[email protected]>
Date:   Fri Mar 9 08:01:35 2018 -0800

    Merge pull request #3556 from skateman/custom-css
    
    Load the custom.css that bypasses the asset pipeline on every screen
    (cherry picked from commit 0e08eda9e9e1f6fccf7154d619d6e49752b1c134)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants