Displays a more informative message on single datasource deletion. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jiri-Kremser could you please review? |
josejulio
force-pushed
the
datasource_more_informative_message
branch
from
6e9afb9 to
e24372a
Compare
|
Checked commit josejulio@e24372a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
lgtm |
|
@martinpovolny Should this be euwe/yes as the other PR? They are for the same BZ. |
|
yes, because of: https://bugzilla.redhat.com/show_bug.cgi?id=1396237 Would be nice if the authors could indicate that. |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1390283