AutomationManagerController & ProviderForemanController - unify model_to_type_name, fixing toolbars #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_to_type_name, fixing toolbars Both controllers are insanely similar, but both use a ManagerControllerMixin. Foreman controller shows configured systems of all kinds, not just Foreman. But trying to show a detail of any such non-foreman system fails with an exception trying to load the right toolbar. Moved the relevant functionality to the mixin and merged so that both can find the right toolbar for either kind of system. Testing: Go to Configuration > Management - Configured Systems tab Click on a system of type Ansible Tower Before: ``` Error caught: [NameError] uninitialized constant ApplicationHelper::Toolbar::XConfiguredSystemCenter /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/inflector/methods.rb:270:in `const_get' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/inflector/methods.rb:270:in `block in constantize' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/inflector/methods.rb:266:in `each' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/inflector/methods.rb:266:in `inject' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/inflector/methods.rb:266:in `constantize' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.1/lib/active_support/core_ext/string/inflections.rb:66:in `constantize' /home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:54:in `predefined_toolbar_class' /home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:63:in `toolbar_class' /home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:17:in `build_toolbar' /home/himdel/manageiq-ui-classic/app/helpers/application_helper/toolbar_builder.rb:6:in `call' /home/himdel/manageiq-ui-classic/app/helpers/application_helper.rb:381:in `build_toolbar' /home/himdel/manageiq-ui-classic/app/controllers/mixins/manager_controller_mixin.rb:395:in `rebuild_toolbars' /home/himdel/manageiq-ui-classic/app/controllers/mixins/manager_controller_mixin.rb:213:in `replace_right_cell' /home/himdel/manageiq-ui-classic/app/controllers/mixins/manager_controller_mixin.rb:178:in `tree_select' /home/himdel/manageiq-ui-classic/app/controllers/application_controller/explorer.rb:193:in `block (2 levels) in generic_x_show' /home/himdel/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionpack-5.0.1/lib/action_controller/metal/mime_responds.rb:201:in `respond_to' /home/himdel/manageiq-ui-classic/app/controllers/application_controller/explorer.rb:186:in `generic_x_show' /home/himdel/manageiq-ui-classic/app/controllers/provider_foreman_controller.rb:194:in `x_show' ``` After: it works :)
|
Cc @lgalis |
This was referenced Feb 10, 2017
Merged
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/657276c6775e753adc2c6f82c43896d0a37bd78c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel - The foreman provider controller should not display Ansible Configured Systems. I will post a PR shortly to only display Foreman Configured Systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both controllers are insanely similar, but both use a ManagerControllerMixin.
Foreman controller shows configured systems of all kinds, not just Foreman.
But trying to show a detail of any such non-foreman system fails with an exception trying to load the right toolbar.
Moved the relevant functionality to the mixin and merged so that both can find the right toolbar for either kind of system.
Testing:
Go to Configuration > Management - Configured Systems tab
Click on a system of type Ansible Tower
Before:
After:
it works :)