Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quadicon image for switch #3489

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

karelhala
Copy link
Contributor

Fixes missing switch icon

This PR removes Switch from disabled quadicon members bacause we want to show quadicon (single quad) for switches.

UI changes

Before

actual 3

After

screenshot from 2018-02-27 17-57-50

BZ

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1546729

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1546729

 Please enter the commit message for your changes. Lines starting
@karelhala
Copy link
Contributor Author

@miq-bot add_label bug,gaprindashvili/yes
@miq-bot assign @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commit karelhala@ba80d65 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@martinpovolny martinpovolny merged commit e87a8d4 into ManageIQ:master Feb 27, 2018
@martinpovolny martinpovolny added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 27, 2018
simaishi pushed a commit that referenced this pull request Mar 8, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 3ce98a9343b220d10bc97457744e5e3a81b1be96
Author: Martin Povolny <[email protected]>
Date:   Tue Feb 27 19:45:42 2018 +0100

    Merge pull request #3489 from karelhala/displaySwitchIcon
    
    Enable quadicon image for switch
    (cherry picked from commit e87a8d45352a0ef0273ff6fb281d4340f310dbf7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants