Policy shield should not be visible for items which have no policies #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug,gaprindashvili/no |
mzazrivec
reviewed
Feb 28, 2018
app/helpers/quadicon_helper.rb
Outdated
| @@ -199,7 +199,9 @@ def single_quad(item) | |||
| if item.kind_of?(VmOrTemplate) && quadicon_policy_sim? && !session[:policies].empty? | |||
| output << flobj_img_small(img_for_compliance(item), "e72") | |||
| end | |||
| output << flobj_img_simple('100/shield.png', "g72") unless item.try(:get_policies).try(:empty?) | |||
| if !item.try(:get_policies).nil? && !item.try(:get_policies).try(:empty?) | |||
There was a problem hiding this comment.
Wouldn't
if item.try(:get_policies).present?do the same thing?
karelhala
force-pushed
the
policyShield
branch
from
ae10f96 to
6eab734
Compare
karelhala
force-pushed
the
policyShield
branch
from
6eab734 to
f0977b2
Compare
|
Checked commit karelhala@f0977b2 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes visible shield for all items
When item hasn't enabled policies, and displays single quad policy shield is visible. That is incorrect, this PR addresses such issue by checking if item can use function
get_policiesUI changes
Before
After