Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enabled and public fields to flavor text summary and show list #3475

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Add enabled and public fields to flavor text summary and show list #3475

merged 1 commit into from
Feb 27, 2018

Conversation

alexander-demicev
Copy link

@alexander-demicev alexander-demicev commented Feb 26, 2018 •
edited
Loading

Add enabled and public fields to flavor text summary
BZ - 1182295

ping @martinpovolny @aufi @mansam

@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2018

Checked commit alexander-demicev@86f1f78 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec
Copy link
Contributor

@alexander-demichev how is this change related to the bug report linked? https://bugzilla.redhat.com/show_bug.cgi?id=1541308

@alexander-demicev
Copy link
Author

@mzazrivec Sorry, wrong link pasted. I changed it.

@mzazrivec
Copy link
Contributor

@aufi Are you OK with this change? Thanks.

@aufi
Copy link
Member

aufi commented Feb 27, 2018

Works for me 👍 Please add a screenshot next time.
image

Regarding to the BZ https://bugzilla.redhat.com/show_bug.cgi?id=1182295, this should be backported to G-branch, ping @Loicavenel

@mzazrivec
Copy link
Contributor

@alexander-demichev @aufi Is modifying the product/views/Flavor.yaml intentional here? The PR title says just "text summary".

@alexander-demicev
Copy link
Author

alexander-demicev commented Feb 27, 2018 •
edited
Loading

@mzazrivec Yes, we need it in show list. I changed PR name

@alexander-demicev alexander-demicev changed the title Add enabled and public fields to flavor text summary Add enabled and public fields to flavor text summary and show list Feb 27, 2018
@Loicavenel
Copy link

This is for 5.9.1

@mzazrivec mzazrivec self-assigned this Feb 27, 2018
@mzazrivec mzazrivec added this to the Sprint 81 Ending Mar 12, 2018 milestone Feb 27, 2018
@mzazrivec mzazrivec merged commit 88af449 into ManageIQ:master Feb 27, 2018
simaishi pushed a commit that referenced this pull request Mar 8, 2018
@mzazrivec @simaishi
Merge pull request #3475 from alexander-demichev/flavor-text-summary
58dd6fc 
Add enabled and public fields to flavor text summary and show list
(cherry picked from commit 88af449)

https://bugzilla.redhat.com/show_bug.cgi?id=1553325
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 58dd6fc5ac099487eae23785c060ff7792dcbf7a
Author: Milan Zázrivec <[email protected]>
Date:   Tue Feb 27 14:37:02 2018 +0100

    Merge pull request #3475 from alexander-demichev/flavor-text-summary
    
    Add enabled and public fields to flavor text summary and show list
    (cherry picked from commit 88af449bb043960d936bba1a3e162927624ddb0c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553325

@alexander-demicev alexander-demicev deleted the flavor-text-summary branch March 8, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
compute/infrastructure enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexander-demicev @miq-bot @mzazrivec @aufi @Loicavenel @simaishi