Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vault credentials to the UI for Embedded Ansible #3468

Merged
merged 9 commits into from
Mar 23, 2018
Merged

Add Vault credentials to the UI for Embedded Ansible #3468

merged 9 commits into from
Mar 23, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Feb 23, 2018 •
edited
Loading

Add Vault credentials to the UI for Embedded Ansible

Dependent on: ManageIQ/manageiq#17048

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1561116

UI changes for ManageIQ/manageiq-providers-ansible_tower#53

screenshot from 2018-02-27 11-21-33
screenshot from 2018-03-22 18-05-59

@miq-bot miq-bot added the wip label Feb 24, 2018
@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch 6 times, most recently from 063958b to d502d71 Compare February 24, 2018 17:04
@lgalis
Copy link
Contributor Author

lgalis commented Feb 27, 2018 •
edited
Loading

@miq-bot add_label enhancement

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

@lgalis Cannot apply the following labels because they are not recognized: automate, gaprinadashvili/no

@lgalis
Copy link
Contributor Author

lgalis commented Feb 27, 2018

@miq-bot add_label gaprindashvili/no

@lgalis
Copy link
Contributor Author

lgalis commented Feb 27, 2018

@miq-bot add_label automation/ansible

@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch 2 times, most recently from 7008ab3 to f03cb0d Compare February 27, 2018 19:14
@lgalis lgalis closed this Feb 28, 2018
@lgalis lgalis reopened this Feb 28, 2018
@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch 5 times, most recently from 481744e to 74bc9f6 Compare March 1, 2018 14:47
@lgalis lgalis changed the title [WIP]Add Vault credentials to the UI for Embedded Ansible Add Vault credentials to the UI for Embedded Ansible Mar 1, 2018
@miq-bot miq-bot removed the wip label Mar 1, 2018
@lgalis lgalis changed the title Add Vault credentials to the UI for Embedded Ansible [WIP]Add Vault credentials to the UI for Embedded Ansible Mar 1, 2018
@miq-bot miq-bot added the wip label Mar 1, 2018
@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch from 51c51ab to afe87f5 Compare March 1, 2018 20:33
@lgalis lgalis changed the title [WIP]Add Vault credentials to the UI for Embedded Ansible Add Vault credentials to the UI for Embedded Ansible Mar 1, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Mar 1, 2018

@h-kataria - please review

@lfu
Copy link
Member

lfu commented Mar 22, 2018

UI change looks good 👍

@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch from 9a6e9e8 to b3a2eed Compare March 22, 2018 21:44
@lgalis lgalis changed the title [WIP] Add Vault credentials to the UI for Embedded Ansible Add Vault credentials to the UI for Embedded Ansible Mar 22, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Mar 22, 2018

@dclarizio or @h-kataria - please review

@miq-bot miq-bot removed the wip label Mar 22, 2018
@lfu lfu mentioned this pull request Mar 23, 2018
Merged
@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch from 63d499f to 6a4534e Compare March 23, 2018 17:18
@lgalis lgalis force-pushed the vault_credentials_for_embedded_ansible branch from 6a4534e to 774c9fe Compare March 23, 2018 18:22
@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2018

Checked commits lgalis/manageiq-ui-classic@666c179~...774c9fe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@lgalis
Copy link
Contributor Author

lgalis commented Mar 23, 2018

@h-kataria - the last commit fixes the infinite spinner when pressing the reset button for Automate Ansible edit page - similar to this #3552

@h-kataria
Copy link
Contributor

looks good, verified in UI

@h-kataria h-kataria added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 23, 2018
@h-kataria h-kataria merged commit 3ba4962 into ManageIQ:master Mar 23, 2018
@lgalis lgalis deleted the vault_credentials_for_embedded_ansible branch March 23, 2018 19:54
simaishi pushed a commit that referenced this pull request Mar 26, 2018
@h-kataria @simaishi
Merge pull request #3468 from lgalis/vault_credentials_for_embedded_a…
b626e82 
…nsible

Add Vault credentials to the UI for Embedded Ansible
(cherry picked from commit 3ba4962)

https://bugzilla.redhat.com/show_bug.cgi?id=1559479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b626e8274b452ef1f7b593a116c4fc68496047e3
Author: Harpreet Kataria <[email protected]>
Date:   Fri Mar 23 15:44:22 2018 -0400

    Merge pull request #3468 from lgalis/vault_credentials_for_embedded_ansible
    
    Add Vault credentials to the UI for Embedded Ansible
    (cherry picked from commit 3ba49622778bf539cb93cfed6c20ffee69a82e06)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559479

@lgalis lgalis mentioned this pull request Mar 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syncrou syncrou syncrou left review comments

Assignees

@h-kataria h-kataria

Labels
automation/ansible enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lgalis @miq-bot @gmcculloug @lfu @h-kataria @simaishi @syncrou