Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTL: Hide pagination on no records #3465

Merged
merged 1 commit into from
Feb 26, 2018
Merged

GTL: Hide pagination on no records #3465

merged 1 commit into from
Feb 26, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Feb 23, 2018 •
edited
Loading

when transitioning from a GTL screen to another,
and the target screen has no records,
the paging toolbar doesn't update and keeps showing the old data.

Hiding on 0 rows.

Cc @karelhala

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1548121

@himdel
GTL: Hide pagination on no records
9fbc691 
when transitioning from a GTL screen to another,
and the target page has no records,
the paging toolbar doesn't update and keeps showing the old data.

Hiding on 0 rows.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1548121
@himdel
Copy link
Contributor Author

himdel commented Feb 23, 2018

Testing:

Go to Ops > accordion Settings
make sure you have some Analysis profiles
make sure you have no Schedules
click Analysis profiles - see GTL with a paging toolbar
click Schedules - see No Records Found

before:
still seeing paging from analysis profiles on schedules screen

after:
no paging toolbar on schedules screen

@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/9fbc691f390928ff2462def547f897852fba8cfe with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Feb 26, 2018
@mzazrivec mzazrivec added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 26, 2018
@mzazrivec mzazrivec merged commit 77153f9 into ManageIQ:master Feb 26, 2018
@himdel himdel deleted the no-records-bz1548121 branch February 26, 2018 15:11
simaishi pushed a commit that referenced this pull request Mar 8, 2018
@mzazrivec @simaishi
Merge pull request #3465 from himdel/no-records-bz1548121
0a7ffb0 
GTL: Hide pagination on no records
(cherry picked from commit 77153f9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553316
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 0a7ffb0a17ff1b7d2917639b1348602a4271defb
Author: Milan Zázrivec <[email protected]>
Date:   Mon Feb 26 15:28:05 2018 +0100

    Merge pull request #3465 from himdel/no-records-bz1548121
    
    GTL: Hide pagination on no records
    (cherry picked from commit 77153f9e4739242a285857eddf61e2e055743e55)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported gtls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himdel @miq-bot @simaishi @mzazrivec