Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issue on "Add New Network Router" screen #3464

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Fix styling issue on "Add New Network Router" screen #3464

merged 1 commit into from
Feb 23, 2018

Conversation

epwinchell
Copy link
Contributor

This PR changes the tag used for "'Fixed IPs" from H2 to H3

https://bugzilla.redhat.com/show_bug.cgi?id=1547878

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/no, formatting/styling

@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/19e8aeb82d381f6c2a5339c65e424457dba17d94 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@epwinchell epwinchell changed the title Fix styling issue on "Add New Network Router" screen [WIP] Fix styling issue on "Add New Network Router" screen Feb 23, 2018
@dclarizio dclarizio merged commit c6a933a into ManageIQ:master Feb 23, 2018
@dclarizio dclarizio changed the title [WIP] Fix styling issue on "Add New Network Router" screen Fix styling issue on "Add New Network Router" screen Feb 23, 2018
@dclarizio dclarizio added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 23, 2018
simaishi pushed a commit that referenced this pull request Mar 8, 2018
Fix styling issue on "Add New Network Router" screen
(cherry picked from commit c6a933a)

https://bugzilla.redhat.com/show_bug.cgi?id=1553311
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 3e8c42d95c5b3a934318c910ead0146121321727
Author: Dan Clarizio <[email protected]>
Date:   Fri Feb 23 15:01:09 2018 -0800

    Merge pull request #3464 from epwinchell/1547878
    
    Fix styling issue on "Add New Network Router" screen
    (cherry picked from commit c6a933a26504a029b64858ea1c6140de341e0c46)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants