MiqPolicy - remove form buttons when cancelling a form or sucessfully saving/adding #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… saving/adding explicitly by passing `:remove_form_buttons => true` to `replace_right_cell` not seeing any previous mechanism to handle this in miq_policy, the `handle_bottom_cell` mechanism used elsewhere doesn't work when transitiononing to a non-GTL screen Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530971
purely to make rubocop happy :) ``` %s/\(:replace_trees => \)\[:/\1%i(/ %s/\(%i([^)]\+\)]/\1)/ %s/\(%i([^)]\+\)[,:]/\1/g %s/\(%i([^)]\+\)[,:]/\1/g %s/\(%i([^)]\+\)[,:]/\1/g %s/\(%i([^)]\+\)[,:]/\1/g ``` + 2 manually (`:replace_trees.*?.*:`)
|
Some comments on commits https://github.com/himdel/manageiq-ui-classic/compare/6ff65d861c37fd3e44b4f8c633b8992431879edf~...8a739359cf15684ea2e779b4d70f299930005801 app/controllers/miq_policy_controller/policy_profiles.rb
|
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/6ff65d861c37fd3e44b4f8c633b8992431879edf~...8a739359cf15684ea2e779b4d70f299930005801 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
MiqPolicy - remove form buttons when cancelling a form or sucessfully saving/adding (cherry picked from commit 27a3e2a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553317
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to any accordion under Control > Explorer (all of them),
Configure > Add a new $thing,
Cancel (or sucessfully save)
Before: you will see the Add/Cancel buttons hanging around on the "list" screen
After: no add/cancel buttons
Done so explicitly by passing
:remove_form_buttons => truetoreplace_right_cell.Not seeing any previous mechanism to handle this in miq_policy, the
handle_bottom_cellmechanism used elsewhere doesn't work when transitiononing to a non-GTL screen.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530971