Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery - move to npm #3450

Merged
merged 1 commit into from
Feb 22, 2018
Merged

jquery - move to npm #3450

merged 1 commit into from
Feb 22, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Feb 21, 2018

Moves jquery from bower to npm. That's it :).

(intentionally not removed from bower resolutions (to prevent it automagically adding >=1.6)

Cc @skateman

(intentionally not removed from bower resolutions (to prevent it automagically adding >=1.6)
@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/cd6c0f11cf2bad0b53c6fc6b7776b1a34a2efd41 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@skateman
Copy link
Member

@himdel you know how to make happy, but you still need to practice with Travis 😉

@himdel
Copy link
Contributor Author

himdel commented Feb 22, 2018

Practiced another punch, and voila.. :)

@mzazrivec mzazrivec self-assigned this Feb 22, 2018
@mzazrivec mzazrivec added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 22, 2018
@mzazrivec mzazrivec merged commit fd9e9be into ManageIQ:master Feb 22, 2018
@himdel himdel deleted the npm-jquery branch February 22, 2018 12:11
@himdel himdel mentioned this pull request Feb 22, 2018
3 tasks
@himdel
Copy link
Contributor Author

himdel commented Aug 3, 2018

issue: #3734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants