Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Expression Editor Styling #3449

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Update Expression Editor Styling #3449

merged 1 commit into from
Feb 22, 2018

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Feb 21, 2018

This PR moves the action buttons below the fields (and changes the font icons to text) as per Issue # 4 here: http://talk.manageiq.org/t/ux-feedback-expression-editor/2927

Old
screen shot 2018-02-21 at 12 27 06 pm

New
screen shot 2018-02-21 at 2 07 01 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label enhancement, formatting/styling, gaprindashvili/no

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@epwinchell
Copy link
Contributor Author

@dclarizio Please test

@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/4751b0c285cb328f93488872be3094fe93698626 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec assigned mzazrivec and unassigned dclarizio Feb 22, 2018
@mzazrivec mzazrivec added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 22, 2018
@mzazrivec mzazrivec merged commit 1e2eca2 into ManageIQ:master Feb 22, 2018
@epwinchell epwinchell deleted the exp_editor_8 branch March 20, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants