Add keymap support for WebMKS remote consoles #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
reviewed
Feb 22, 2018
| @@ -28,6 +28,11 @@ | |||
| $('#ctrlaltdel').on('click', function() { | |||
| wmks.sendCAD(); | |||
| }); | |||
|
|
|||
| $('#keymap').on('change', function() { | |||
| console.log(this.value); | |||
There was a problem hiding this comment.
Is the log here intentional?
There was a problem hiding this comment.
yes @mzazrivec testing your review skills 😉
skateman
force-pushed
the
webmks-keymap
branch
from
faa69ef to
45b897b
Compare
|
Checked commit skateman@45b897b with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bmclaughlin Could you test this one please? Thank you. |
bmclaughlin
approved these changes
Mar 1, 2018
simaishi
pushed a commit
that referenced
this pull request
Mar 8, 2018
Add keymap support for WebMKS remote consoles (cherry picked from commit 30a591b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553329
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 10, 2018
Add keymap support for WebMKS remote consoles (cherry picked from commit 30a591b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553331
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into the VMware HTML Console Programming Guide and on page 8 found that WebMKS has support for key mapping between a few keyboard types. It is not a universal solution, but solves the problem of special characters if both the VM's and the client's keyboard layout is one of the supported keyboards.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1545927
@bmclaughlin can you test this please?
@miq-bot add_label gaprindashvili/yes, fine/yes, bug, consoles