Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vm / orch. stack / instance / service unretire #3428

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

mzazrivec
Copy link
Contributor

  1. have a retired vm
  2. go to that vm's details page and hit 'Set retirement date' button
  3. click on the input field (it render the datetimepicker widget & clear the input field)
  4. Save button should become available

https://bugzilla.redhat.com/show_bug.cgi?id=1534962

@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2018

Checked commit mzazrivec@8fbf835 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@JPrause
Copy link
Member

JPrause commented Feb 20, 2018

@mzazrivec who can help review this PR?

@mzazrivec
Copy link
Contributor Author

@himdel Perhaps?

@himdel himdel self-assigned this Feb 20, 2018
@himdel
Copy link
Contributor

himdel commented Feb 20, 2018

LGTM, verified clicking the datepicker when the date is invalid (in the past) makes the save button enabled.

Nothing else seems to break and the change should be harmless 👍

(Still wondering how to reach this bug in production though, since the VM will already have been retired :))

(waiting for travis)

@himdel himdel merged commit 4ec02e5 into ManageIQ:master Feb 20, 2018
@mzazrivec mzazrivec deleted the support_for_unretire branch February 20, 2018 16:57
simaishi pushed a commit that referenced this pull request Mar 8, 2018
Support for vm / orch. stack / instance / service unretire
(cherry picked from commit 4ec02e5)

https://bugzilla.redhat.com/show_bug.cgi?id=1553243
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 4e81fe24379c8abdd9f41bc71a8df6bb45a22a75
Author: Martin Hradil <[email protected]>
Date:   Tue Feb 20 16:56:37 2018 +0000

    Merge pull request #3428 from mzazrivec/support_for_unretire
    
    Support for vm / orch. stack / instance / service unretire
    (cherry picked from commit 4ec02e58f338ea51b47fd77814379ad75c09786a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants