Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for selecting radio button on Catalog Item edit screen #3413

Merged

Conversation

bmclaughlin
Copy link
Contributor

The 'Use Existing' Dialog radio button was not cooperating when it should have been checked by default.

@miq-bot add_labels bug, services

https://bugzilla.redhat.com/show_bug.cgi?id=1543136

@miq-bot
Copy link
Member

miq-bot commented Feb 15, 2018

Checked commit bmclaughlin@96a4bf2 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Feb 16, 2018
@mzazrivec mzazrivec added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 16, 2018
@mzazrivec mzazrivec merged commit 384041f into ManageIQ:master Feb 16, 2018
@bmclaughlin bmclaughlin deleted the fix-use-existing-radio-button-logic branch February 16, 2018 12:16
simaishi pushed a commit that referenced this pull request Mar 8, 2018
…on-logic

Fix logic for selecting radio button on Catalog Item edit screen
(cherry picked from commit 384041f)

https://bugzilla.redhat.com/show_bug.cgi?id=1553227
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit 29460f6d246f3d82825cb496b8ad56656adbf815
Author: Milan Zázrivec <[email protected]>
Date:   Fri Feb 16 12:05:26 2018 +0100

    Merge pull request #3413 from bmclaughlin/fix-use-existing-radio-button-logic
    
    Fix logic for selecting radio button on Catalog Item edit screen
    (cherry picked from commit 384041f329db01b0297e70e69e5a94962c71333f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants