-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Azure Instance container display of file name and mode descriptions #3373
Fixes Azure Instance container display of file name and mode descriptions #3373
Conversation
36da8ba
to
64851bb
Compare
I really don't get the fix here, it seems for me the content form left column should be in right column. |
64851bb
to
cbb0283
Compare
@Loicavenel I originally only addressed the BZ. Code has been refactored to make the page and hard drive params more legible. |
@h-kataria Please review. |
The two CI failures |
@GregP please look at test failures they look related to code changes |
4d41f8d
to
b9f5f52
Compare
b9f5f52
to
bb55ae0
Compare
Checked commit GregP@bb55ae0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@h-kataria Spec refactored/amended and added, please review. |
Fixes Azure Instance container display of file name and mode descriptions (cherry picked from commit 7a41058) https://bugzilla.redhat.com/show_bug.cgi?id=1552886
Gaprindashvili backport details:
|
@GregP This was refactored in |
Fixes display of container hard drive filename and mode descriptions for Azure Instances, as well as other providers. Code now accounts for when values/settings are either nil or blank (text) strings. All hard drive parameters were shifted to display in the right hand column on the page for display consistency and viewing legibility. See screen shots bellow.
https://bugzilla.redhat.com/show_bug.cgi?id=1536681
Screen shot before code fix:
Screen shot of Azure Instance post code fix:
Screen shot of Amazon Instance display post fix:
Screen shot of OpenStack Instance display post code fix, notice 2 hard drives listed: