Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Azure Instance container display of file name and mode descriptions #3373

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

GregP
Copy link
Contributor

@GregP GregP commented Feb 5, 2018

Fixes display of container hard drive filename and mode descriptions for Azure Instances, as well as other providers. Code now accounts for when values/settings are either nil or blank (text) strings. All hard drive parameters were shifted to display in the right hand column on the page for display consistency and viewing legibility. See screen shots bellow.

https://bugzilla.redhat.com/show_bug.cgi?id=1536681

Screen shot before code fix:
azure instance container file name and mode display prior to code fix

Screen shot of Azure Instance post code fix:
azure instance container post code fix

Screen shot of Amazon Instance display post fix:
amazon instance container post code fix

Screen shot of OpenStack Instance display post code fix, notice 2 hard drives listed:
openstack instance container with 2 hard drives post code fix

@GregP GregP force-pushed the fix_azure_provider_description branch 2 times, most recently from 36da8ba to 64851bb Compare February 6, 2018 03:34
@Loicavenel
Copy link

I really don't get the fix here, it seems for me the content form left column should be in right column.

@GregP
Copy link
Contributor Author

GregP commented Feb 6, 2018

@Loicavenel I originally only addressed the BZ. Code has been refactored to make the page and hard drive params more legible.

@GregP
Copy link
Contributor Author

GregP commented Feb 6, 2018

@h-kataria Please review.

@mzazrivec
Copy link
Contributor

The two CI failures undefined method 'upcase' for nil:NilClass are related.

@h-kataria
Copy link
Contributor

@GregP please look at test failures they look related to code changes

@GregP GregP force-pushed the fix_azure_provider_description branch 2 times, most recently from 4d41f8d to b9f5f52 Compare February 7, 2018 22:46
@GregP GregP force-pushed the fix_azure_provider_description branch from b9f5f52 to bb55ae0 Compare February 7, 2018 22:53
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2018

Checked commit GregP@bb55ae0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@GregP
Copy link
Contributor Author

GregP commented Feb 7, 2018

@h-kataria Spec refactored/amended and added, please review.

@mzazrivec mzazrivec added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 8, 2018
@mzazrivec mzazrivec merged commit 7a41058 into ManageIQ:master Feb 8, 2018
simaishi pushed a commit that referenced this pull request Mar 7, 2018
Fixes Azure Instance container display of file name and mode descriptions
(cherry picked from commit 7a41058)

https://bugzilla.redhat.com/show_bug.cgi?id=1552886
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 2ce29f77462c09492de7aa8f4b999d3cb362c8af
Author: Milan Zázrivec <[email protected]>
Date:   Thu Feb 8 12:40:54 2018 +0100

    Merge pull request #3373 from GregP/fix_azure_provider_description
    
    Fixes Azure Instance container display of file name and mode descriptions
    (cherry picked from commit 7a41058cedd42be52001fb372681386c9d5d072e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552886

@simaishi
Copy link
Contributor

simaishi commented Apr 9, 2018

@GregP This was refactored in master branch and I'm not sure where this goes in Fine branch... Please create a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants