Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for available expression fields for groups #3336

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Fix for available expression fields for groups #3336

merged 2 commits into from
Feb 1, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Jan 29, 2018 •
edited
Loading

Fixes the expression editor for Group Custom buttons and Group enablement Expression

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1535063

Steps for Testing/QA

  • Add a custom button for a Group. The enablement expression will only allow the selection of tags without this PR.
  • With a Group custom button with an enablement expression added, an error occurs when selecting a group in Configuration->Access control

Before:

screenshot from 2018-01-30 16-37-40

After:
screenshot from 2018-01-30 16-40-54

@miq-bot miq-bot added the wip label Jan 29, 2018
@lgalis lgalis force-pushed the group_tags_filter_expression_fix branch 4 times, most recently from fc6ec78 to 85b9521 Compare January 30, 2018 20:58
@lgalis lgalis force-pushed the group_tags_filter_expression_fix branch from 85b9521 to 03d224d Compare January 30, 2018 21:10
@lgalis lgalis mentioned this pull request Jan 30, 2018
Closed
@lgalis
Copy link
Contributor Author

lgalis commented Jan 30, 2018

@miq-bot add_label bug, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2018

Checked commits lgalis/manageiq-ui-classic@6808d80~...03d224d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@lgalis lgalis changed the title [WIP] Fix for available expression fields for groups Fix for available expression fields for groups Jan 30, 2018
@miq-bot miq-bot removed the wip label Jan 30, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Jan 31, 2018

@h-kataria - please review

@h-kataria h-kataria self-assigned this Feb 1, 2018
@h-kataria
Copy link
Contributor

verified in UI, good to merge.

@h-kataria h-kataria added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 1, 2018
@h-kataria h-kataria merged commit 1ebed36 into ManageIQ:master Feb 1, 2018
@lgalis lgalis deleted the group_tags_filter_expression_fix branch February 1, 2018 19:52
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@h-kataria @simaishi
Merge pull request #3336 from lgalis/group_tags_filter_expression_fix
30ab847 
Fix for available expression fields for groups
(cherry picked from commit 1ebed36)

https://bugzilla.redhat.com/show_bug.cgi?id=1552874
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 30ab847b25baab9cdcb512e9bf27f8c59a143621
Author: Harpreet Kataria <[email protected]>
Date:   Thu Feb 1 14:51:10 2018 -0500

    Merge pull request #3336 from lgalis/group_tags_filter_expression_fix
    
    Fix for available expression fields for groups
    (cherry picked from commit 1ebed36703bec4588277d16f8f70b8aa7a6118a0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
automation/automate bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @h-kataria @simaishi