Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role(assert) check for cloud network in subnet new form #3333

Conversation

lpichler
Copy link
Contributor

Add role(assert) check for cloud network in subnet new form and for related toolbar.

User needs to have also cloud_network_show_list role feature to access this new subnet screen

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1520651
This feature has been missed in d68cd78

Reproducer

Networks -> Subnet -> add new (it can be hidden if user don't have permission)
cc @mzazrivec @himdel
@miq-bot assign @martinpovolny
@miq-bot add_label bug, blocker

@miq-bot
Copy link
Member

miq-bot commented Jan 29, 2018

Checked commit lpichler@ac03612 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec assigned mzazrivec and unassigned martinpovolny Jan 30, 2018
@mzazrivec mzazrivec added this to the Sprint 79 Ending Feb 12, 2018 milestone Jan 30, 2018
@mzazrivec mzazrivec merged commit 908f3ba into ManageIQ:master Jan 30, 2018
@lpichler lpichler deleted the add_assert_check_for_cloud_network_in_subnet_screen branch January 30, 2018 09:24
simaishi pushed a commit that referenced this pull request Jan 30, 2018
…work_in_subnet_screen

Add role(assert) check for cloud network in subnet new form
(cherry picked from commit 908f3ba)

https://bugzilla.redhat.com/show_bug.cgi?id=1535479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 6be04b40490c016d3a1af3bab7bd85207c984dca
Author: Milan Zázrivec <[email protected]>
Date:   Tue Jan 30 10:16:30 2018 +0100

    Merge pull request #3333 from lpichler/add_assert_check_for_cloud_network_in_subnet_screen
    
    Add role(assert) check for cloud network in subnet new form
    (cherry picked from commit 908f3bae313f84105dcc280ff043930879920b2c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1535479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants