Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vertical lines from gettext strings #3314

Merged

Conversation

mzazrivec
Copy link
Contributor

Having | in gettext strings repeatedly causes problems with translators, who confuse this with a Model|Attribute string.

Having | in gettext strings repeatedly causes problems with translators,
who confuse this with a Model|Attribute string.
@miq-bot
Copy link
Member

miq-bot commented Jan 24, 2018

Checked commits mzazrivec/manageiq-ui-classic@3539b19~...0372c32 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 8 offenses detected

app/helpers/quadicon_helper.rb

@chessbyte chessbyte self-assigned this Jan 25, 2018
@chessbyte chessbyte merged commit 190984f into ManageIQ:master Jan 25, 2018
@chessbyte chessbyte added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 25, 2018
@mzazrivec mzazrivec deleted the remove_vertical_line_from_gettext_strings branch January 25, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants