Adding UI support for Pod to PersistentVolume relationship. #3299

nimrodshn · 2018-01-23T08:34:50Z

Adding UI support for Pod to PersistentVolume relationship.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1435235
GIF:

cc: @himdel @kbrock @zeari

nimrodshn · 2018-01-23T08:39:20Z

@himdel @kbrock the reason I had to add "PersistentVolume" => "persistent_volumes" to HAS_ASSOCIATION was that otherwise get_parent_targets in miq_report/search.rb would derive it from the base class (see get_parent_targets line 67 [1]), which is ContainerVolumes, and that would lead to an empty report.

Credit to @kbrock for finding this and saving my life 🥇

[1]https://github.com/ManageIQ/manageiq/blob/d992f980a857db789c8aa8b3636bf1b6559ca539/app/models/miq_report/search.rb#L67

nimrodshn · 2018-01-23T08:42:45Z

@miq-bot add_label gaprindashvili/yes, providers/containers, bug

zeari · 2018-01-23T10:20:36Z

app/helpers/container_group_helper/textual_summary.rb

@@ -16,7 +16,7 @@ def textual_group_relationships
      _("Relationships"),
      %i(
        ems container_project container_services container_replicator containers container_node
-        lives_on container_images
+        lives_on container_images pod_to_persistent_volume_relationship


How about persistent_volumes instead 😅

nimrodshn · 2018-01-23T11:09:04Z

@zeari fixed. 👍

kbrock

Looks good.
Glad you found the hash that was causing havoc on the search.rb code. very good find.

I don't know too much about the ui code - so I'm not sure if my 👍 means anything

kbrock · 2018-01-24T14:23:43Z

app/helpers/container_summary_helper.rb

@@ -171,7 +171,8 @@ def textual_persistent_volume
  end

  def textual_persistent_volumes
-    textual_link(@record.persistent_volumes)
+    link = url_for_only_path(:id => @record.id, :action => "show", :display => "persistent_volumes")


did you still need to use url_for_only_path now that you taught the system how to deal with persistent_volumes? um, did you test if the url "just works"?

himdel · 2018-01-29T15:19:49Z

app/views/layouts/listnav/_container_group.html.haml

@@ -36,3 +36,10 @@
        = multiple_relationship_link(@record, :container)
        = multiple_relationship_link(@record, :container_image)
        = single_relationship_link(@record, :container_node)
+        - if @record.number_of(:persistent_volumes).zero?


This is wrong, you need to use one of the *relationship_link functions (those also check the user is allowed to see the thing..)

Any reason you can't do that?

nimrodshn · 2018-02-06T09:37:04Z

@himdel fixed - ~~but in order for the link to work to work I had to add some line to miq_product_features.yml so now this is pending ManageIQ/manageiq#16956 😢~~

himdel · 2018-02-07T13:57:19Z

app/views/layouts/listnav/_container_group.html.haml

@@ -36,3 +36,4 @@
        = multiple_relationship_link(@record, :container)
        = multiple_relationship_link(@record, :container_image)
        = single_relationship_link(@record, :container_node)
+        = multiple_relationship_link(@record, :persistent_volumes)


:persistent_volume .. this should make multiple_relationship_link use the right rbac feature, while still accessing the right data (as it does call table_name.pluralize for that).

(so no need for the other pr after all, I think)

Adding UI support for pv to pod relationship adding PersistentVolume to HAS_ASSOCATION refactor code adding relationship to navbar refactoring textual_persistent_volumes works without the link fixed listnav fixing listanv

nimrodshn · 2018-02-07T14:12:15Z

@himdel thanks mate!

miq-bot · 2018-02-07T14:19:05Z

Checked commit nimrodshn@909739e with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

nimrodshn · 2018-02-08T08:41:50Z

@himdel PTAL?

himdel · 2018-02-08T16:07:45Z

LGTM, verified in the UI :)

Adding UI support for Pod to PersistentVolume relationship. (cherry picked from commit 2341a39) https://bugzilla.redhat.com/show_bug.cgi?id=1552889

simaishi · 2018-03-07T21:51:30Z

Gaprindashvili backport details:

$ git log -1
commit 5bac531ee00dfcfe4e383e7d61c3215db5da1675
Author: Martin Hradil <[email protected]>
Date:   Thu Feb 8 17:07:37 2018 +0100

    Merge pull request #3299 from nimrodshn/support_pv_to_pod_relationship
    
    Adding UI support for Pod to PersistentVolume relationship.
    (cherry picked from commit 2341a397a870611ed0d0de5019c7f29017b150e1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552889

nimrodshn force-pushed the support_pv_to_pod_relationship branch 2 times, most recently from 940bb69 to 812e779 Compare January 23, 2018 09:17

nimrodshn changed the title ~~Adding UI support for PersistentVolume to Pod relationship.~~ Adding UI support for Pod to PersistentVolume relationship. Jan 23, 2018

himdel added bug compute/containers gaprindashvili/yes labels Jan 23, 2018

zeari reviewed Jan 23, 2018

View reviewed changes

nimrodshn force-pushed the support_pv_to_pod_relationship branch from 812e779 to 9167739 Compare January 23, 2018 11:07

kbrock reviewed Jan 24, 2018

View reviewed changes

nimrodshn force-pushed the support_pv_to_pod_relationship branch from 9167739 to 5a9ce8f Compare January 28, 2018 12:34

himdel reviewed Jan 29, 2018

View reviewed changes

nimrodshn force-pushed the support_pv_to_pod_relationship branch from 5a9ce8f to f586d16 Compare February 6, 2018 09:29

nimrodshn mentioned this pull request Feb 6, 2018

Adding persistent_volumes_show_list as a feature. ManageIQ/manageiq#16956

Closed

himdel reviewed Feb 7, 2018

View reviewed changes

initial commit

909739e

Adding UI support for pv to pod relationship adding PersistentVolume to HAS_ASSOCATION refactor code adding relationship to navbar refactoring textual_persistent_volumes works without the link fixed listnav fixing listanv

nimrodshn force-pushed the support_pv_to_pod_relationship branch from f586d16 to 909739e Compare February 7, 2018 14:11

himdel self-assigned this Feb 8, 2018

himdel merged commit 2341a39 into ManageIQ:master Feb 8, 2018

himdel added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 8, 2018

simaishi added the gaprindashvili/backported label Mar 7, 2018

simaishi removed the gaprindashvili/yes label Mar 7, 2018

nimrodshn mentioned this pull request Jul 24, 2018

report_data does not return report fot /container_group/report_data?model=persistent_volumes #1854

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding UI support for Pod to PersistentVolume relationship. #3299

Adding UI support for Pod to PersistentVolume relationship. #3299

nimrodshn commented Jan 23, 2018 •

edited

Loading

nimrodshn commented Jan 23, 2018 •

edited

Loading

nimrodshn commented Jan 23, 2018

zeari Jan 23, 2018

nimrodshn commented Jan 23, 2018

kbrock left a comment

kbrock Jan 24, 2018

himdel Jan 29, 2018 •

edited

Loading

nimrodshn commented Feb 6, 2018 •

edited

Loading

himdel Feb 7, 2018 •

edited

Loading

nimrodshn commented Feb 7, 2018

miq-bot commented Feb 7, 2018

nimrodshn commented Feb 8, 2018

himdel commented Feb 8, 2018

simaishi commented Mar 7, 2018

Adding UI support for Pod to PersistentVolume relationship. #3299

Adding UI support for Pod to PersistentVolume relationship. #3299

Conversation

nimrodshn commented Jan 23, 2018 • edited Loading

nimrodshn commented Jan 23, 2018 • edited Loading

nimrodshn commented Jan 23, 2018

zeari Jan 23, 2018

Choose a reason for hiding this comment

nimrodshn commented Jan 23, 2018

kbrock left a comment

Choose a reason for hiding this comment

kbrock Jan 24, 2018

Choose a reason for hiding this comment

himdel Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

nimrodshn commented Feb 6, 2018 • edited Loading

himdel Feb 7, 2018 • edited Loading

Choose a reason for hiding this comment

nimrodshn commented Feb 7, 2018

miq-bot commented Feb 7, 2018

nimrodshn commented Feb 8, 2018

himdel commented Feb 8, 2018

simaishi commented Mar 7, 2018

nimrodshn commented Jan 23, 2018 •

edited

Loading

nimrodshn commented Jan 23, 2018 •

edited

Loading

himdel Jan 29, 2018 •

edited

Loading

nimrodshn commented Feb 6, 2018 •

edited

Loading

himdel Feb 7, 2018 •

edited

Loading