Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTL: do not sparkle unless we are going to navigate. #3288

Merged
merged 1 commit into from
Jan 19, 2018
Merged

GTL: do not sparkle unless we are going to navigate. #3288

merged 1 commit into from
Jan 19, 2018

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Jan 19, 2018 •
edited
Loading

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1536378

Some rows are clickable, some are not in this GTL. So testing just showUrl is not usefull.

@martinpovolny
Copy link
Member Author

ping @h-kataria, @himdel

@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2018

Checked commit martinpovolny@0291aa4 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@himdel himdel self-assigned this Jan 19, 2018
@himdel
Copy link
Contributor

himdel commented Jan 19, 2018 •
edited
Loading

Aah, if this is per-item, makes sense :)

Merging when green.

(JS specs stalled on travis, restarted)

@h-kataria
Copy link
Contributor

verified in UI, fixes inifinite spinner when clicking on rows in tasks table with no links.

@h-kataria h-kataria added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 19, 2018
@h-kataria h-kataria merged commit 995933a into ManageIQ:master Jan 19, 2018
simaishi pushed a commit that referenced this pull request Jan 19, 2018
@h-kataria @simaishi
Merge pull request #3288 from martinpovolny/tasks_infinispinner
6a029bb 
GTL: do not sparkle unless we are going to navigate.
(cherry picked from commit 995933a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536664
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 6a029bbe729cee496fcb2dab6a294c7dea47288a
Author: Harpreet Kataria <[email protected]>
Date:   Fri Jan 19 15:34:42 2018 -0500

    Merge pull request #3288 from martinpovolny/tasks_infinispinner
    
    GTL: do not sparkle unless we are going to navigate.
    (cherry picked from commit 995933a7ce8371909389e09e8e3fd7c7938ca646)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
blocker bug gaprindashvili/backported gtls tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @himdel @h-kataria @simaishi