Add scopes for MiqRequest

[tumido]

Change the MiqRequest query builder to use named_scopes instead of filter.

Depends on: ManageIQ/manageiq#16843
Depends on: ManageIQ/manageiq#16939
Depends on: ManageIQ/manageiq#16950

• Get rid of filter, use scopes instead
• Investigate when the different branches in page_display_options are used (the first two seems redundant and the third seems unused)
• Clean up and update testcases
• Change request_types_for_model magic to something readible

[tumido]

cc @martinpovolny
@miq-bot add_label pending core, wip, refactoring

[tumido]

@miq-bot remove_label wip
@miq-bot add_label gtls, requests

[Ladas]

@tumido nice work 👏 👏 , it looks like tough refactoring, untangling this.

@martinpovolny I wonder if the specs are enough to say this all works? Do we have also some integration tests somewhere? Or should we click it through?

[martinpovolny]

I merged the backend PR. Here I am waiting for the specs that we discussed today. Thx!

[tumido]

@martinpovolny 👍 I'm on it! 😉

[tumido]

@miq-bot remove_label wip

[tumido]

The lines above are required, otherwise the report_data post request is broken. Rails can't handle nested arrays on request properly. (When sending the request.) This is the way to bypass it.

If :named_scope is sent the old way this is what happens:

Sent data (includes):

"named_scope" => [["with_requester", 80000000000202]]

Received by controller:

"named_scope" => [["with_requester"], [80000000000202]]

[miq-bot]

Some comments on commit tumido@cd812b1

spec/controllers/miq_request_controller_spec.rb

• ⚠️ - 154 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commit tumido@cd812b1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 3 offenses detected

app/controllers/miq_request_controller.rb

• ❗ - Line 432, Col 7 - Layout/FirstParameterIndentation - Indent the first parameter one step more than MiqRequest.where(.
• ❗ - Line 55, Col 8 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.

spec/support/controller_helper.rb

• ❗ - Line 122, Col 9 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: post.