Layouts - always create paging_div, hidden if needed

[himdel]

content layout - always creates paging_div, after #main-content
center div with/no listnav - create paging_div conditionally, after #main-content
center div dashboard - no paging_div, but no ajax transitions to other screens either

this updates center div with/without listnav to always create paging_div, hidden if necessary

that way, ReportDataController.prototype.movePagination should always succeed, and the pagination will never appear above GTL.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1501035

(also https://bugzilla.redhat.com/show_bug.cgi?id=1535946 which is marked as a dup)

[h-kataria]

@karelhala @martinpovolny please review.

[himdel]

Not yet please .. this is still missing the bit where we show the div when hidden, but only in cases where we don't set @pages to nil.

[himdel]

Testing:

1. Add some infrastructure provider.
2. Navigate to Compute/Infrastructure/Datastores.
3. Open details screen of some datastore.
4. Click on "Managed/Registered VMs" and "Managed/Unregistered VMs" fields in Relationship table

For me, the URL is /storage/show/10000000000026?display=registered_vms.

The page is using center_div_no_listnav, layout_uses_paging? returns false, @in_a_form is nil => paging should not be visible in that screen.

EDIT: except that @pages is set, so it will be visible unless we explicitly (@pages = nil)

[himdel]

Testing 2:

1. (clean session, fresh after login)
2. Go to Ops
3. Switch to Diagnostics accordion
4. Switch to Workers tab in server detail

before/after: no paging visible

5. Reload the screen

before: paging visible
after: no paging visible

TODO: ^this is not true yet

EDIT: this is true as well

[karelhala]

Codewise looks good and simple. Will test on couple of screens if it won't break anything.

[himdel]

This should be ready for testing...

I'm pretty sure this should mean no more paging above gtl.

I'm almost sure paging should always be there when it should.

I'm a bit worried that form buttons may get hidden on forms which don't explicitly show paging_div.

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/65b5d1c6c25d1ef59126e3a2f1cebb6c4dbf36d5~...989dc324bc6cc3ab93180350485d57bd37b01aa4 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.5-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[ZitaNemeckova]

• Testing 1 Layouts - always create paging_div, hidden if needed #3271 (comment)
• Testing 2 Layouts - always create paging_div, hidden if needed #3271 (comment)
• Test random explorer pages (GTL -> form -> GTL + reload)

Tested in UI. LGTM 👍

[karelhala]

Tested on multiple edit/config/policy screens and everything looks good.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 1ce45d66c70c44b10233933ccad8953114c74d71
Author: Martin Povolny <[email protected]>
Date:   Fri Jan 19 16:24:27 2018 +0100

    Merge pull request #3271 from himdel/paging-show-bz1501035
    
    Layouts - always create paging_div, hidden if needed
    (cherry picked from commit b0e99b6b084e8aa5289e192e55728e42fd926159)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536563