Fix rendering of flash message when running check compliance #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits mzazrivec/manageiq-ui-classic@86435ea~...0ef7f9a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, flash message matches other dashboards, and the default render flash case in Tested in the UI |
simaishi
pushed a commit
that referenced
this pull request
Jan 11, 2018
Fix rendering of flash message when running check compliance (cherry picked from commit 183a259) https://bugzilla.redhat.com/show_bug.cgi?id=1533522
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigate to infra / container provider summary, switch to dashboard view, hit 'Check Compliance of Last known Configuration' button.
Previously, the button action would render full page (html). Now the action will render a javascript flash message.
https://bugzilla.redhat.com/show_bug.cgi?id=1510340