-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHSM form - use observe queue for submit #3191
Conversation
wip because the template is not actually used on that screen, apparently EDIT: now using the right template |
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
except for the save button, which comes from current: Validate is using Save is using |
@miq-bot remove_label wip |
this allows miqAjaxButton to be queued in the same queue used by miq-observe, thus waiting for any miq-observe requests to complete before submitting the form https://bugzilla.redhat.com/show_bug.cgi?id=1532201
validate: this is a straight transform from link_to + RJS remote: true, to a button using miqAjaxButton except adding observe:true so that the validate action never happens before any pending edit actions (auth_credentials2 is only ever used from that single Red Hat Updates edit form) save: just enabling observe=true for x_edit_buttons in settings_rhn_edit Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532201
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/e1f81401153cdc2a3b0d94f7836ed5f6114ec8c4~...f3b9b791e8db0f9c4145fe395f9046b2ff97d4c4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
Ops (Configuration) > Settings, select Region, tab Red Hat Updates
Edit Registration - fill out inputs too quickly and hit Register
clicking the Register button too fast would mean the attempt to save the form happened before the last input changed
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532201