Add rbac checks for cloud 'new' screens #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits lpichler/manageiq-ui-classic@4aefac9~...1ac6415 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Jan 8, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 9, 2018
…screens Add rbac checks for cloud 'new' screens (cherry picked from commit c511c93) https://bugzilla.redhat.com/show_bug.cgi?id=1532655
|
Gaprindashvili backport details: |
|
@lpichler can this be |
|
Backported to Fine via #3326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were couple places in new cloud form without RBAC filtering and this PRs is adding RBAC here.
Affected screen new form screens:
Host Aggregates,
Tenant,
Flavour,
Subnets
Cloud Network is missing(regard to the description in BZ) but there is already RBAC check.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1516229
@miq-bot add_label gaprindashvili/yes, bug
@miq-bot assign @martinpovolny
cc @mzazrivec