Require privilege network providers and cloud tenants for new cloud network, cloud subnet, network router form

[lpichler]

imagine that you are the user without allowed section network providers.
then when you go to Network -> Networks|Subnets|Network Routers-> Add new and select any network provider, it will end with error(there is video in BZ)

so I am adding the assert for this feature and I am adding the method role_allows - it check if user has feature related to Network Providers(ems_network_show_list)

@miq-bot assign @himdel
@miq-bot add_label bug, blocker, gaprindashvili/yes

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1526803

[lpichler]

Last 2 commits are extending this and adding also privilege for Cloud Tenants as requirement (according this different but related BZ https://bugzilla.redhat.com/show_bug.cgi?id=1520651 )

[lpichler]

cc @martinpovolny

[himdel]

Test failures look relevant ;)

[lpichler]

[lpichler]

should be fixed 👍

[h-kataria]

@lpichler @himdel i think with role_allows check in place https://github.com/ManageIQ/manageiq-ui-classic/pull/3165/files#diff-fd8f9ab59428266a5f699efcb9933979R7 we shouldn't need those additional assert_priviliges calls

[lpichler]

@h-kataria I guess it is beneficial to have these checks in the controller as well for cases if somebody would perform the controller action but not from the toolbar button, but manually.

[himdel]

@h-kataria That wouldn't stop users from being able to open the screen manually.. But then again, if they do, it just won't work for them.. Shouldn't be a security issue, agreed :)

Then again, it makes it clearer what is really needed by that screen..

[miq-bot]

Checked commits lpichler/manageiq-ui-classic@994be6f~...a7f3c5c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 9 offenses detected

spec/controllers/cloud_network_controller_spec.rb

• ❗ - Line 74, Col 62 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 83, Col 52 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 95, Col 64 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

spec/controllers/cloud_subnet_controller_spec.rb

• ❗ - Line 74, Col 62 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 83, Col 52 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 95, Col 64 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

spec/controllers/network_router_controller_spec.rb

• ❗ - Line 74, Col 62 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 83, Col 52 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 95, Col 64 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[himdel]

(restarted travis after #3227, hoping for green)

[lpichler]

@himdel it is green 👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 0fc57bc4336c884e4f040eb28c13c12da4f0d513
Author: Martin Hradil <[email protected]>
Date:   Fri Jan 12 16:06:08 2018 +0100

    Merge pull request #3165 from lpichler/require_ems_network_show_list_product_feature_for_cloud_network_new_form
    
    Require privilege network providers and cloud tenants for new cloud network, cloud subnet, network router form
    (cherry picked from commit f244a4e3e6ddc878e38eee2c9701664cea7c1021)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1534057