Availability Zone has only Management Events in Timelines #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Policy Events are not yet implemented for Availability Zones this hides them until they will be implemented.
|
@ZitaNemeckova Cannot apply the following label because they are not recognized: gapridashvili/yes |
|
@miq-bot add_label gaprindashvili/yes |
ohadlevy
reviewed
Jan 3, 2018
| @@ -1,3 +1,7 @@ | |||
| module AvailabilityZoneHelper | |||
| include_concern 'TextualSummary' | |||
|
|
|||
| def accessible_select_event_types | |||
| [[_('Management Events'), 'timeline']] | |||
There was a problem hiding this comment.
shouldn't timeline be i18n too?
There was a problem hiding this comment.
It's value in select picker not text displayed to user so it should never be translated :)
There was a problem hiding this comment.
And rspec is added :)
|
Checked commits ZitaNemeckova/manageiq-ui-classic@7a8306a~...2851067 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper.rb
spec/helpers/availability_zone_helper_spec.rb
|
|
looks good. |
simaishi
pushed a commit
that referenced
this pull request
Jan 4, 2018
Availability Zone has only Management Events in Timelines (cherry picked from commit 46e1d85) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531308
|
Gaprindashvili backport details: |
|
@ZitaNemeckova I assume you meant |
|
@simaishi I did. Thanks :) |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Availability Zone has only Management Events in Timelines (cherry picked from commit 46e1d85) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533167
|
Fine backport details: |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Policy Events are not yet implemented for Availability Zones this hides them until they will be implemented. And it's present in Darga as well.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1523663
Compute -> Cloud -> Availability Zone -> select one that has timelines -> Monitoring -> Timelines
Before:
After applying Policy Events
After:
@miq-bot add_label bug, blocker, compute/cloud, gaprindashvili/yes, euwe/yes, darga/yes