Adding default labels 'com.redhat.component' to chargback assignments #3144

nimrodshn · 2017-12-28T15:49:23Z

What This Does
Makes the label com.redhat.component as default label for docker container images in chargback assignments screen.

Why
This makes it easier for customers to leverage RH product labels, instead of scanning through what could be large number of image labels.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1417236
GIF:

cc: @himdel , @zeari

nimrodshn · 2017-12-28T15:53:12Z

@zeari not really sure what to put in the popover, any suggestions?

nimrodshn · 2017-12-28T15:54:27Z

@miq-bot add_label bug, compute/containers

nimrodshn · 2017-12-28T15:55:13Z

@zeari should this be for gaprindashvili?

nimrodshn · 2017-12-29T06:28:17Z

cc: @simon3z @serenamarie125

zeari · 2017-12-31T12:24:09Z

app/controllers/chargeback_controller.rb

@@ -747,10 +747,17 @@ def get_tags_all(category)
    classification.entries.each { |e| @edit[:cb_assign][:tags][e.id.to_s] = e.description } if classification
  end

+  DEFAULT_CHARGEBACK_LABELS = ["com.redhat.component"]


This should be seeded from a file but im really not sure whats the correct way 😓

Yeah.. Let's wait for @himdel to respond on this..

If this is just one constant, a file would probably be an overkill, this is fine 👍 (at least until it becomes some structured data, then we can deal with creating a yaml and importing during seed).

(If this is something that's not really specific to chargeback but to container images in general, maybe the string should live in the model, idk. But I'm OK with this.)

himdel · 2018-01-02T17:16:52Z

This should close #2606, right?

himdel · 2018-01-02T17:23:56Z

Assuming you find a text for the popover, could you move it to a separate partial please?

Just so that we don't have to repeat the whole bit... something like...

app/views/shared/_popover.html.haml

%a{:"data-toggle" => "popover",
   :"data-html"    => "true",
   :"data-content" => text,
   :"data-placement" => "top"}
  %span.pf-blue-info.pficon.pficon-info

:javascript
  $(document).ready(function() {
    $('[data-toggle=popover]').popovers()
  });

and use

render :partial => "shared/popover", :locals => { :text => _("Foo") }

(also, mising i18n now ;))

(If you don't find any text ... well, it didn't have any help text before, and the BZ is not about missing help, so .. not a blocker if we don't add a popover.)

nimrodshn · 2018-01-03T08:59:15Z

@himdel Yeah I too don't see any reference to "help missing" in the BZ only thing is that @serenamarie125 commented about that in the previous PR (#2606) so I didn't want to ignore her comment even though I too don't think it is necessary. I will wait for her to take a peek and give opinion and if it is not necassary I will drop the popover.

nimrodshn · 2018-01-04T11:35:09Z

@himdel, I removed the popover - It is not necessary for the BZ. PTAL?
(Updated the GIF ⏫ )

fix-minor mistakes missing default options freeze constant removing popover and adding comments

miq-bot · 2018-01-08T10:17:35Z

Checked commit nimrodshn@55af067 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

himdel · 2018-01-08T16:29:16Z

LGTM, merged :)

(we probably still want the popover, but didn't want to block the PR on an unrelated change)

@nimrodshn Is this meant for gaprindashvili?

nimrodshn · 2018-01-09T08:27:58Z

BZ is on cfme-future so nope.

simaishi · 2018-01-25T18:14:19Z

BZ is now marked for z-stream. This can be marked as gaprindashvili/yes?

nimrodshn · 2018-01-25T18:37:50Z

yes 👍 @simaishi

Adding default labels 'com.redhat.component' to chargback assignments (cherry picked from commit f5e4dfc) https://bugzilla.redhat.com/show_bug.cgi?id=1552704

simaishi · 2018-03-07T16:38:31Z

Gaprindashvili backport details:

$ git log -1
commit bdfd80c2f246af517f34597addced64e032618af
Author: Martin Hradil <[email protected]>
Date:   Mon Jan 8 17:28:44 2018 +0100

    Merge pull request #3144 from nimrodshn/default-labels
    
    Adding default labels 'com.redhat.component' to chargback assignments
    (cherry picked from commit f5e4dfc220c0e0b3045a1c7b9b5d7c61496ae8f7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552704

nimrodshn changed the title ~~Adding default labels~~ Adding default labels 'com.redhat.component' to chargback assignments Dec 28, 2017

nimrodshn changed the title ~~Adding default labels 'com.redhat.component' to chargback assignments~~ [WIP] Adding default labels 'com.redhat.component' to chargback assignments Dec 28, 2017

miq-bot added bug compute/containers labels Dec 28, 2017

nimrodshn force-pushed the default-labels branch 3 times, most recently from a713b90 to f6dde8a Compare December 28, 2017 17:10

zeari reviewed Dec 31, 2017

View reviewed changes

mzazrivec added the wip label Jan 2, 2018

nimrodshn force-pushed the default-labels branch 3 times, most recently from 7b9c3a2 to 2678047 Compare January 4, 2018 11:32

nimrodshn changed the title ~~[WIP] Adding default labels 'com.redhat.component' to chargback assignments~~ Adding default labels 'com.redhat.component' to chargback assignments Jan 4, 2018

miq-bot removed the wip label Jan 4, 2018

zeari mentioned this pull request Jan 4, 2018

[WIP] Show 'default' chargeback label assignments before the rest of the list #2606

Closed

adding default image labels to chargback assignment.

55af067

fix-minor mistakes missing default options freeze constant removing popover and adding comments

nimrodshn force-pushed the default-labels branch from 2678047 to 55af067 Compare January 8, 2018 10:16

himdel self-assigned this Jan 8, 2018

himdel added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 8, 2018

himdel merged commit f5e4dfc into ManageIQ:master Jan 8, 2018

simaishi added the gaprindashvili/yes label Jan 25, 2018

simaishi pushed a commit that referenced this pull request Mar 7, 2018

Merge pull request #3144 from nimrodshn/default-labels

bdfd80c

Adding default labels 'com.redhat.component' to chargback assignments (cherry picked from commit f5e4dfc) https://bugzilla.redhat.com/show_bug.cgi?id=1552704

simaishi added gaprindashvili/backported and removed gaprindashvili/yes labels Mar 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding default labels 'com.redhat.component' to chargback assignments #3144

Adding default labels 'com.redhat.component' to chargback assignments #3144

nimrodshn commented Dec 28, 2017 •

edited

Loading

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 29, 2017

zeari Dec 31, 2017

nimrodshn Dec 31, 2017

himdel Jan 2, 2018

himdel Jan 2, 2018 •

edited

Loading

himdel commented Jan 2, 2018

himdel commented Jan 2, 2018 •

edited

Loading

nimrodshn commented Jan 3, 2018

nimrodshn commented Jan 4, 2018 •

edited

Loading

miq-bot commented Jan 8, 2018

himdel commented Jan 8, 2018 •

edited

Loading

nimrodshn commented Jan 9, 2018

simaishi commented Jan 25, 2018

nimrodshn commented Jan 25, 2018

simaishi commented Mar 7, 2018

Adding default labels 'com.redhat.component' to chargback assignments #3144

Adding default labels 'com.redhat.component' to chargback assignments #3144

Conversation

nimrodshn commented Dec 28, 2017 • edited Loading

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 28, 2017

nimrodshn commented Dec 29, 2017

zeari Dec 31, 2017

Choose a reason for hiding this comment

nimrodshn Dec 31, 2017

Choose a reason for hiding this comment

himdel Jan 2, 2018

Choose a reason for hiding this comment

himdel Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

himdel commented Jan 2, 2018

himdel commented Jan 2, 2018 • edited Loading

nimrodshn commented Jan 3, 2018

nimrodshn commented Jan 4, 2018 • edited Loading

miq-bot commented Jan 8, 2018

himdel commented Jan 8, 2018 • edited Loading

nimrodshn commented Jan 9, 2018

simaishi commented Jan 25, 2018

nimrodshn commented Jan 25, 2018

simaishi commented Mar 7, 2018

nimrodshn commented Dec 28, 2017 •

edited

Loading

himdel Jan 2, 2018 •

edited

Loading

himdel commented Jan 2, 2018 •

edited

Loading

nimrodshn commented Jan 4, 2018 •

edited

Loading

himdel commented Jan 8, 2018 •

edited

Loading