Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services: fix styling on detail page reload. #3085

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Services: fix styling on detail page reload. #3085

merged 1 commit into from
Dec 18, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Dec 16, 2017 •
edited
Loading

Testing:

  • go to "Services" --> "My services"
  • click on a service to get it's details displayed (with a GTL grid showing related VMs for example)
  • press CTRL-R or reload
  • observe that the background of the main content ares is (not) grey.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1517910

@miq-bot
Copy link
Member

miq-bot commented Dec 16, 2017

Checked commit martinpovolny@512d5ac with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Dec 18, 2017
@mzazrivec mzazrivec added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 18, 2017
@mzazrivec mzazrivec merged commit b7e0f61 into ManageIQ:master Dec 18, 2017
simaishi pushed a commit that referenced this pull request Dec 18, 2017
@mzazrivec @simaishi
Merge pull request #3085 from martinpovolny/sand_hack_reload
f34a34c 
Services: fix styling on detail page reload.
(cherry picked from commit b7e0f61)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1517910
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f34a34ce864144e4d842f0c3eea422f3b5b1550b
Author: Milan Zázrivec <[email protected]>
Date:   Mon Dec 18 12:34:42 2017 +0100

    Merge pull request #3085 from martinpovolny/sand_hack_reload
    
    Services: fix styling on detail page reload.
    (cherry picked from commit b7e0f61a4366b957104063aabeae2292aba813d8)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1517910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

@himdel himdel Awaiting requested review from himdel

@h-kataria h-kataria Awaiting requested review from h-kataria

Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported gtls services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpovolny @miq-bot @simaishi @mzazrivec