Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in @in_a_form to report_data call #3068

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

h-kataria
Copy link
Contributor

Added changes to pass in @in_a_form so gtl_view does not set advanced search variables in @edit while rendering forms such as Policy Assignment form.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1524862

@dclarizio @martinpovolny please review.

Added changes to pass in `@in_a_form` so gtl_view does not set advanced search variables in @edit while rendering forms such as Policy Assignment form.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1524862
@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2017

Checked commit h-kataria@924efc3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

spec/controllers/vm_infra_controller_spec.rb

@martinpovolny martinpovolny merged commit d4f2be2 into ManageIQ:master Dec 15, 2017
@martinpovolny martinpovolny added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 15, 2017
simaishi pushed a commit that referenced this pull request Dec 18, 2017
Passing in `@in_a_form` to report_data call
(cherry picked from commit d4f2be2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527104
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c178f2f902ec6a654c228f6523f24cf35e47da14
Author: Martin Povolny <[email protected]>
Date:   Fri Dec 15 20:26:54 2017 +0100

    Merge pull request #3068 from h-kataria/policy_assignment_fix
    
    Passing in `@in_a_form` to report_data call
    (cherry picked from commit d4f2be2fdbd1a82dc232223c60593327c5f9abbd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527104

@h-kataria h-kataria deleted the policy_assignment_fix branch January 12, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants