Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to edit Chargeback rate after resetting changes #3048

Merged

Conversation

hstastna
Copy link

fixing #2744

Enable to edit Chargeback rate again after clicking on Reset button in Cloud Intel -> Chargeback -> Rates tab.

Before:
reset1

After:
reset2

fixing ManageIQ#2744

Enable to edit Chargeback rate again after clicking on Reset button
in Cloud Intel -> Chargeback -> Rates tab.
@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2017

Checked commit hstastna@82bd1ab with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue 👍

@mzazrivec mzazrivec self-assigned this Dec 14, 2017
@mzazrivec mzazrivec added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 14, 2017
@mzazrivec mzazrivec merged commit bffd8c0 into ManageIQ:master Dec 14, 2017
@mzazrivec
Copy link
Contributor

@hstastna Is this gaprindashvili/yes ?

@hstastna
Copy link
Author

@mzazrivec This problem occurs in gaprindashvili, too, so I assume - yes. But now, as I am looking at it, we don't have a BZ for it, just an issue here in github. Should I create a BZ for it, too?

@mzazrivec
Copy link
Contributor

@h-kataria bz should not be necessary.

simaishi pushed a commit that referenced this pull request Dec 14, 2017
Enable to edit Chargeback rate after resetting changes
(cherry picked from commit bffd8c0)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 36ec8dc96d293d7420e10225c9ff484e0a772872
Author: Milan Zázrivec <[email protected]>
Date:   Thu Dec 14 11:08:35 2017 +0100

    Merge pull request #3048 from hstastna/Unable_edit_Chargeback_rate_Reset
    
    Enable to edit Chargeback rate after resetting changes
    (cherry picked from commit bffd8c06aeb312a93ce3ce26b095c89485090a20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants