Name the tags on the topology screens based on its classifications

[skateman]

The name attribute on tags is displaying the full tag URI instead of a human-readable name. The tags we want to display on topology screens always provide a related Classification object with an appropriate description. This object always has a parent Classification also with the description. Using these objects we can build the desired human-readable tag name by joining the two descriptions together.

As the tag name is being displayed on a tooltip with a Name: prefix before, I did not wanted to use a second colon for joining the two descriptions. Instead of that I am dropping the prefix for tags.

Before:

After:

Depends on:
ManageIQ/manageiq#16607
#3007

https://bugzilla.redhat.com/show_bug.cgi?id=1467805

@miq-bot add_label bug, pending core, gaprindashvili/yes, topology

[epwinchell]

@miq-bot assign @dclarizio

[epwinchell]

@dclarizio @skateman

From the VM Summary:

[dclarizio]

Another showing multiple tags in a category:

[skateman]

@epwinchell changed it to A: B

[dclarizio]

@skateman So is Name:, Type:, and Status: a standard topology popup or could tags have their own text format? Like:

Department: Accounting | Engineering
Type: Tag

Especially, since Status has no real meaning for a tag anyway.

[skateman]

@dclarizio I'm not saying it can't be done, but it would add extra complexity into the codebase. But if @himdel approves, I'm okay with it...

[himdel]

I'm OK with it too.. one extra if for tags won't kill us :).

[martinpovolny]

Marking as WIP based on the conversation.

[skateman]

Adjusted based on the suggestions, updated the screenshots...

[dclarizio]

@skateman was it not easy to remove "Status" from the tag popup? They really don't have a status. Let me know, otherwise, we can merge when green.

Also removing pending core label as the depends on PRs have been merged.

[miq-bot]

Checked commit skateman@44bd5a4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[skateman]

@dclarizio updated code and screenshot

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 49b6b3fd89710ae6f031903d613caa0c6cf3b839
Author: Dan Clarizio <[email protected]>
Date:   Thu Dec 14 13:37:21 2017 -0800

    Merge pull request #3034 from skateman/topology-tag-naming
    
    Name the tags on the topology screens based on its classifications
    (cherry picked from commit d7681c09db29f2207040ea311332c38ffd3dbef7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1526582