Display the VNC start/end port when adding a vmware provider #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIR, the inconsistency existed from the very beginning - even when the form was non-angular. LGTM (Nice-to-have: Validation for the ports that enforces only numbers. But since it did not exist before, we can add it later if required) |
|
Checked commit skateman@9520bfc with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
Display the VNC start/end port when adding a vmware provider (cherry picked from commit 46f0608) https://bugzilla.redhat.com/show_bug.cgi?id=1524714
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 10, 2018
Display the VNC start/end port when adding a vmware provider (cherry picked from commit 46f0608) https://bugzilla.redhat.com/show_bug.cgi?id=1565366
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a vmware infra provider, the VNC start/end port fields aren't displayed. However, when editing the same provider they are there. I don't know the reason behind this inconsistency, but I got a 🪲 for it so here's the fix.
Before:
After:
@miq-bot add_label bug
https://bugzilla.redhat.com/show_bug.cgi?id=1514594
@AparnaKarve could you please review?