Fixed invalid HTML markup in drift fonticons #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@47669cd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
ohadlevy
reviewed
Dec 11, 2017
| @@ -1223,7 +1223,7 @@ def drift_add_diff_image(idx, val) | |||
|
|
|||
| def drift_add_image_col(idx, img_src, img_bkg, val) | |||
| html = ViewHelper.content_tag(:div, :class => img_bkg) do | |||
| ViewHelper.tag(:i, :class => img_src, :title => val) | |||
| ViewHelper.content_tag(:i, nil, :class => img_src, :title => val) | |||
|
@skateman Tested. Looks good. |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
Fixed invalid HTML markup in drift fonticons (cherry picked from commit 46531e5) https://bugzilla.redhat.com/show_bug.cgi?id=1524711
|
Gaprindashvili backport details: |
simaishi
added
gaprindashvili/backported
fine/yes
and removed
gaprindashvili/yes
labels
simaishi
pushed a commit
that referenced
this pull request
Dec 13, 2017
Fixed invalid HTML markup in drift fonticons (cherry picked from commit 46531e5) https://bugzilla.redhat.com/show_bug.cgi?id=1525563
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
taghelper method in Rails is a little bit inconsistent when it's about self-closing tags. It works well with aninputfield, but it fails to work with anitag that we're using for fonticons. This causes random duplication of tags when displaying a drift history of a host. Forcing the tag to be closed by using an emptycontent_taginstead solves the issue.Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1466402
@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @epwinchell