Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'Provision VMs' button in Datastores and Clusters #298

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Enable 'Provision VMs' button in Datastores and Clusters #298

merged 2 commits into from
Feb 7, 2017

Conversation

bmclaughlin
Copy link
Contributor

@bmclaughlin bmclaughlin commented Feb 3, 2017 •
edited by miq-bot
Loading

Also added specs for additional instances of the 'Provision VMs' button.

https://bugzilla.redhat.com/show_bug.cgi?id=1373850

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Feb 3, 2017
@bmclaughlin bmclaughlin force-pushed the add-provision-button-in-datastore-and-cluster branch from 0598bfb to 52ef36e Compare February 3, 2017 21:06
@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2017

Checked commits bmclaughlin/manageiq-ui-classic@cb8d2af~...52ef36e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@miq-bot miq-bot added the euwe/no label Feb 7, 2017
skateman
skateman approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@skateman
Copy link
Member

skateman commented Feb 7, 2017

@miq-bot assign @martinpovolny

@mzazrivec mzazrivec added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
@mzazrivec mzazrivec merged commit 24a0bd6 into ManageIQ:master Feb 7, 2017
@bmclaughlin bmclaughlin deleted the add-provision-button-in-datastore-and-cluster branch February 7, 2017 14:26
@simaishi
Copy link
Contributor

simaishi commented Mar 3, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 2172e6c59111e3bd963e281b4d5cb665d7a8393b
Author: Milan Zázrivec <[email protected]>
Date:   Tue Feb 7 11:15:20 2017 +0100

    Merge pull request #298 from bmclaughlin/add-provision-button-in-datastore-and-cluster
    
    Enable 'Provision VMs' button in Datastores and Clusters
    (cherry picked from commit 24a0bd6586b7637d4a14e8cc3b7b6137abb55950)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1386342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug compute/infrastructure euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bmclaughlin @miq-bot @skateman @simaishi @martinpovolny @dclarizio @mzazrivec