Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cap & U option styling #2961

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Update Cap & U option styling #2961

merged 1 commit into from
Dec 5, 2017

Conversation

epwinchell
Copy link
Contributor

This PR updates the Cap & U options to use PF "form-horizontal" styling

Old
screen shot 2017-12-05 at 4 53 34 pm

After
screen shot 2017-12-05 at 4 48 52 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label enhancement, formatting/styling

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/c3c9339f20a943f5cb673f52634928159496de24 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 3 offenses detected

app/views/layouts/_perf_options.html.haml

  • ⚠️ - Line 14 - Prefer using YAML.safe_load over YAML.load.
  • ⚠️ - Line 17 - Missing curly braces around a hash parameter.
  • ⚠️ - Line 19 - Line is too long. [181/160]

@dclarizio dclarizio merged commit cf1b8e9 into ManageIQ:master Dec 5, 2017
@dclarizio dclarizio added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 5, 2017
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 92d5ed775d5106bab523715f55f172ef63c4e9f2
Author: Dan Clarizio <[email protected]>
Date:   Tue Dec 5 14:33:18 2017 -0800

    Merge pull request #2961 from epwinchell/c_and_u_update
    
    Update Cap & U option styling
    (cherry picked from commit cf1b8e9b194ce76e4b24de280a861505bfdbefcc)

simaishi pushed a commit that referenced this pull request Dec 11, 2017
@simaishi
Merge pull request #2961 from epwinchell/c_and_u_update
92d5ed7 
Update Cap & U option styling
(cherry picked from commit cf1b8e9)
@epwinchell epwinchell deleted the c_and_u_update branch March 20, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
enhancement formatting/styling gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epwinchell @miq-bot @simaishi @dclarizio